[PATCH 2/6] arm64: stacktrace: delete PCS comment
Madhavan T. Venkataraman
madvenka at linux.microsoft.com
Wed Apr 13 08:02:49 PDT 2022
On 4/13/22 09:59, Mark Rutland wrote:
> The comment at the top of stacktrace.c isn't all that helpful, as it's
> not associated with the code which inspects the frame record, and the
> code example isn't representative of common code generation today.
>
> Delete it.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <mark.rutland at arm.com>
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Madhavan T. Venkataraman <madvenka at linux.microsoft.com>
> Cc: Mark Brown <broonie at kernel.org>
> Cc: Will Deacon <will at kernel.org>
> ---
> arch/arm64/kernel/stacktrace.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
> index 94932ade5c79..08af9ca9a845 100644
> --- a/arch/arm64/kernel/stacktrace.c
> +++ b/arch/arm64/kernel/stacktrace.c
> @@ -18,21 +18,6 @@
> #include <asm/stack_pointer.h>
> #include <asm/stacktrace.h>
>
> -/*
> - * AArch64 PCS assigns the frame pointer to x29.
> - *
> - * A simple function prologue looks like this:
> - * sub sp, sp, #0x10
> - * stp x29, x30, [sp]
> - * mov x29, sp
> - *
> - * A simple function epilogue looks like this:
> - * mov sp, x29
> - * ldp x29, x30, [sp]
> - * add sp, sp, #0x10
> - */
> -
> -
> static notrace void start_backtrace(struct stackframe *frame, unsigned long fp,
> unsigned long pc)
> {
Reviewed-by: Madhavan T. Venkataraman <madvenka at linux.microsoft.com>
More information about the linux-arm-kernel
mailing list