[PATCH] misc: atmel-ssc: fix error check return value of platform_get_irq()

cgel.zte at gmail.com cgel.zte at gmail.com
Wed Apr 13 02:32:22 PDT 2022


From: Lv Ruyi <lv.ruyi at zte.com.cn>

platform_get_irq() return negative value on failure, so null check of
ssc->irq is incorrect. Fix it by comparing whether it is less than zero.

Reported-by: Zeal Robot <zealci at zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi at zte.com.cn>
---
 drivers/misc/atmel-ssc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index d6cd5537126c..5e7b290d9515 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -232,7 +232,7 @@ static int ssc_probe(struct platform_device *pdev)
 	clk_disable_unprepare(ssc->clk);
 
 	ssc->irq = platform_get_irq(pdev, 0);
-	if (!ssc->irq) {
+	if (ssc->irq < 0) {
 		dev_dbg(&pdev->dev, "could not get irq\n");
 		return -ENXIO;
 	}
-- 
2.25.1




More information about the linux-arm-kernel mailing list