[PATCH v3] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF

[Arnd Bergmann]

On Sat, Apr 9, 2022 at 2:05 PM Janusz Krzysztofik <jmkrzyszt at gmail.com> wrote:
> On Tuesday, 5 April 2022 11:39:05 CEST Arnd Bergmann wrote:
> > This all looks good to me. I have now rebased my omap1 multiplatform series
> > on the latest kernel and integrated some of your new work, see [1].
> >
> > I have also finished up the multiplatform conversion for all other ARMv4T
> > and ARMv5 platforms and sent them out, hopefully we are getting into the
> > endgame with this.
> >
> > Are you able to test your CCF patches in combination with my series?
> > It would be great if we could get this all working in time for 5.19.
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=omap1-multiplatform-5.18
>
> Your branch with my CCF patches on top of it works for me on my OMAP1510
> based Amstrad Delta with the below fix:
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index 8cafe7819e13..292fcb0a24fc 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1623,7 +1623,7 @@ static int omapfb_do_probe(struct platform_device *pdev,
>
>         init_state = 0;
>
> -       if (pdev->num_resources != 1) {
> +       if (pdev->num_resources != 2) {
>                 dev_err(&pdev->dev, "probed for an unknown device\n");
>                 r = -ENODEV;
>                 goto cleanup;
>
> Amstrad Delta uses internal LCD controller, then the second IRQ (for sossi)
> is not needed, but your patch "fbdev: omap: pass irqs as resource" adds
> both to the array of omapfb resources and sets pdev->num_resources = 2.

Thanks a lot for testing, I folded your fixup into the corresponding
patch now and uploaded the new branch. Can you also send me latest
version of the patches you added on top so I can make them part of the
series before the final patch?

I would then send the complete series for another (possibly last)
round of review and try to get it merged for 5.19 if there are no other
concerns.

I have already merged the (comparatively simple) multiplatform conversion
changes for s3c24xx, ep93xx, ixp4xx and iop into the soc tree, they should
show up in the linux-next on Monday.

        Arnd