[arm:zii 52/146] drivers/net/ethernet/microchip/lan966x/lan966x_main.c:631:9: error: implicit declaration of function 'phylink_set_pcs'; did you mean 'phylink_stop'?
kernel test robot
lkp at intel.com
Fri Apr 8 18:16:12 PDT 2022
tree: git://git.armlinux.org.uk/~rmk/linux-arm.git zii
head: 9b613822d82aaff62445bab79522b8675612d979
commit: 540ce47af588dbabf68f7f50d0b459c70df811c2 [52/146] net: phylink: remove phylink_set_pcs()
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20220409/202204090959.q7lqQyV6-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add arm git://git.armlinux.org.uk/~rmk/linux-arm.git
git fetch --no-tags arm zii
git checkout 540ce47af588dbabf68f7f50d0b459c70df811c2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/microchip/lan966x/lan966x_main.c: In function 'lan966x_probe_port':
>> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:631:9: error: implicit declaration of function 'phylink_set_pcs'; did you mean 'phylink_stop'? [-Werror=implicit-function-declaration]
631 | phylink_set_pcs(phylink, &port->phylink_pcs);
| ^~~~~~~~~~~~~~~
| phylink_stop
cc1: some warnings being treated as errors
vim +631 drivers/net/ethernet/microchip/lan966x/lan966x_main.c
d28d6d2e37d10d Horatiu Vultur 2021-11-29 562
db8bcaad539314 Horatiu Vultur 2021-11-29 563 static int lan966x_probe_port(struct lan966x *lan966x, u32 p,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 564 phy_interface_t phy_mode,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 565 struct fwnode_handle *portnp)
db8bcaad539314 Horatiu Vultur 2021-11-29 566 {
db8bcaad539314 Horatiu Vultur 2021-11-29 567 struct lan966x_port *port;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 568 struct phylink *phylink;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 569 struct net_device *dev;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 570 int err;
db8bcaad539314 Horatiu Vultur 2021-11-29 571
db8bcaad539314 Horatiu Vultur 2021-11-29 572 if (p >= lan966x->num_phys_ports)
db8bcaad539314 Horatiu Vultur 2021-11-29 573 return -EINVAL;
db8bcaad539314 Horatiu Vultur 2021-11-29 574
d28d6d2e37d10d Horatiu Vultur 2021-11-29 575 dev = devm_alloc_etherdev_mqs(lan966x->dev,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 576 sizeof(struct lan966x_port), 8, 1);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 577 if (!dev)
db8bcaad539314 Horatiu Vultur 2021-11-29 578 return -ENOMEM;
db8bcaad539314 Horatiu Vultur 2021-11-29 579
d28d6d2e37d10d Horatiu Vultur 2021-11-29 580 SET_NETDEV_DEV(dev, lan966x->dev);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 581 port = netdev_priv(dev);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 582 port->dev = dev;
db8bcaad539314 Horatiu Vultur 2021-11-29 583 port->lan966x = lan966x;
db8bcaad539314 Horatiu Vultur 2021-11-29 584 port->chip_port = p;
db8bcaad539314 Horatiu Vultur 2021-11-29 585 lan966x->ports[p] = port;
db8bcaad539314 Horatiu Vultur 2021-11-29 586
d28d6d2e37d10d Horatiu Vultur 2021-11-29 587 dev->max_mtu = ETH_MAX_MTU;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 588
d28d6d2e37d10d Horatiu Vultur 2021-11-29 589 dev->netdev_ops = &lan966x_port_netdev_ops;
12c2d0a5b8e2a1 Horatiu Vultur 2021-11-29 590 dev->ethtool_ops = &lan966x_ethtool_ops;
6d2c186afa5d5d Horatiu Vultur 2021-12-18 591 dev->features |= NETIF_F_HW_VLAN_CTAG_TX |
6d2c186afa5d5d Horatiu Vultur 2021-12-18 592 NETIF_F_HW_VLAN_STAG_TX;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 593 dev->needed_headroom = IFH_LEN * sizeof(u32);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 594
e18aba8941b40b Horatiu Vultur 2021-11-29 595 eth_hw_addr_gen(dev, lan966x->base_mac, p + 1);
e18aba8941b40b Horatiu Vultur 2021-11-29 596
0c94d657d2a416 Horatiu Vultur 2021-12-23 597 lan966x_mac_learn(lan966x, PGID_CPU, dev->dev_addr, HOST_PVID,
e18aba8941b40b Horatiu Vultur 2021-11-29 598 ENTRYTYPE_LOCKED);
e18aba8941b40b Horatiu Vultur 2021-11-29 599
d28d6d2e37d10d Horatiu Vultur 2021-11-29 600 port->phylink_config.dev = &port->dev->dev;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 601 port->phylink_config.type = PHYLINK_NETDEV;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 602 port->phylink_pcs.poll = true;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 603 port->phylink_pcs.ops = &lan966x_phylink_pcs_ops;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 604
d28d6d2e37d10d Horatiu Vultur 2021-11-29 605 port->phylink_config.mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
d28d6d2e37d10d Horatiu Vultur 2021-11-29 606 MAC_10 | MAC_100 | MAC_1000FD | MAC_2500FD;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 607
d28d6d2e37d10d Horatiu Vultur 2021-11-29 608 __set_bit(PHY_INTERFACE_MODE_MII,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 609 port->phylink_config.supported_interfaces);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 610 __set_bit(PHY_INTERFACE_MODE_GMII,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 611 port->phylink_config.supported_interfaces);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 612 __set_bit(PHY_INTERFACE_MODE_SGMII,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 613 port->phylink_config.supported_interfaces);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 614 __set_bit(PHY_INTERFACE_MODE_QSGMII,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 615 port->phylink_config.supported_interfaces);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 616 __set_bit(PHY_INTERFACE_MODE_1000BASEX,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 617 port->phylink_config.supported_interfaces);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 618 __set_bit(PHY_INTERFACE_MODE_2500BASEX,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 619 port->phylink_config.supported_interfaces);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 620
d28d6d2e37d10d Horatiu Vultur 2021-11-29 621 phylink = phylink_create(&port->phylink_config,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 622 portnp,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 623 phy_mode,
d28d6d2e37d10d Horatiu Vultur 2021-11-29 624 &lan966x_phylink_mac_ops);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 625 if (IS_ERR(phylink)) {
d28d6d2e37d10d Horatiu Vultur 2021-11-29 626 port->dev = NULL;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 627 return PTR_ERR(phylink);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 628 }
d28d6d2e37d10d Horatiu Vultur 2021-11-29 629
d28d6d2e37d10d Horatiu Vultur 2021-11-29 630 port->phylink = phylink;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 @631 phylink_set_pcs(phylink, &port->phylink_pcs);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 632
d28d6d2e37d10d Horatiu Vultur 2021-11-29 633 err = register_netdev(dev);
d28d6d2e37d10d Horatiu Vultur 2021-11-29 634 if (err) {
d28d6d2e37d10d Horatiu Vultur 2021-11-29 635 dev_err(lan966x->dev, "register_netdev failed\n");
d28d6d2e37d10d Horatiu Vultur 2021-11-29 636 return err;
d28d6d2e37d10d Horatiu Vultur 2021-11-29 637 }
d28d6d2e37d10d Horatiu Vultur 2021-11-29 638
6d2c186afa5d5d Horatiu Vultur 2021-12-18 639 lan966x_vlan_port_set_vlan_aware(port, 0);
6d2c186afa5d5d Horatiu Vultur 2021-12-18 640 lan966x_vlan_port_set_vid(port, HOST_PVID, false, false);
6d2c186afa5d5d Horatiu Vultur 2021-12-18 641 lan966x_vlan_port_apply(port);
6d2c186afa5d5d Horatiu Vultur 2021-12-18 642
db8bcaad539314 Horatiu Vultur 2021-11-29 643 return 0;
db8bcaad539314 Horatiu Vultur 2021-11-29 644 }
db8bcaad539314 Horatiu Vultur 2021-11-29 645
:::::: The code at line 631 was first introduced by commit
:::::: d28d6d2e37d10d607f931d25c835a0bd94d370e3 net: lan966x: add port module support
:::::: TO: Horatiu Vultur <horatiu.vultur at microchip.com>
:::::: CC: David S. Miller <davem at davemloft.net>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the linux-arm-kernel
mailing list