[soc:pxa-multiplatform-5.18 30/48] arch/mips/alchemy/devboards/db1300.c:744:10: error: 'struct wm97xx_mach_ops' has no member named 'irq_enable'

[Arnd Bergmann]

On Tue, Apr 5, 2022 at 8:42 PM kernel test robot <lkp at intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git pxa-multiplatform-5.18
> head:   4a123f8a2d8aa2e0a82f2bfdf313b1cb797c19e2
> commit: 356d02c6854766d6d062f7dd75a0c88d3a09a96c [30/48] Input: wm97xx - get rid of irq_enable method in wm97xx_mach_ops
> config: mips-db1xxx_defconfig (https://download.01.org/0day-ci/archive/20220406/202204060221.lOETuc06-lkp@intel.com/config)
> compiler: mipsel-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?id=356d02c6854766d6d062f7dd75a0c88d3a09a96c
>         git remote add soc https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git
>         git fetch --no-tags soc pxa-multiplatform-5.18
>         git checkout 356d02c6854766d6d062f7dd75a0c88d3a09a96c
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/alchemy/devboards/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp at intel.com>

I addressed this by dropping the callback from db1300 as well:

--- a/arch/mips/alchemy/devboards/db1300.c
+++ b/arch/mips/alchemy/devboards/db1300.c
@@ -732,16 +732,7 @@ static struct platform_device db1300_lcd_dev = {
 /**********************************************************************/

 #if IS_ENABLED(CONFIG_TOUCHSCREEN_WM97XX)
-static void db1300_wm97xx_irqen(struct wm97xx *wm, int enable)
-{
-       if (enable)
-               enable_irq(DB1300_AC97_PEN_INT);
-       else
-               disable_irq_nosync(DB1300_AC97_PEN_INT);
-}
-
 static struct wm97xx_mach_ops db1300_wm97xx_ops = {
-       .irq_enable     = db1300_wm97xx_irqen,
        .irq_gpio       = WM97XX_GPIO_3,
 };

Fairly sure this is the right approach.

Manuel, if you want to give the wm97xx changes a try on Alchemy,
see

git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git pxa-multiplatform-5.18
I'm planning to send out the series for 5.19 if the other arm multiplatform
changes work out first.

         Arnd

> All error/warnings (new ones prefixed by >>):
>
> >> arch/mips/alchemy/devboards/db1300.c:744:10: error: 'struct wm97xx_mach_ops' has no member named 'irq_enable'
>      744 |         .irq_enable     = db1300_wm97xx_irqen,
>          |          ^~~~~~~~~~
> >> arch/mips/alchemy/devboards/db1300.c:744:27: warning: initialization of 'int' from 'void (*)(struct wm97xx *, int)' makes integer from pointer without a cast [-Wint-conversion]
>      744 |         .irq_enable     = db1300_wm97xx_irqen,
>          |                           ^~~~~~~~~~~~~~~~~~~
>    arch/mips/alchemy/devboards/db1300.c:744:27: note: (near initialization for 'db1300_wm97xx_ops.acc_enabled')
>    arch/mips/alchemy/devboards/db1300.c:799:12: warning: no previous prototype for 'db1300_dev_setup' [-Wmissing-prototypes]
>      799 | int __init db1300_dev_setup(void)
>          |            ^~~~~~~~~~~~~~~~
>    arch/mips/alchemy/devboards/db1300.c:868:12: warning: no previous prototype for 'db1300_board_setup' [-Wmissing-prototypes]
>      868 | int __init db1300_board_setup(void)
>          |            ^~~~~~~~~~~~~~~~~~
>
>
> vim +744 arch/mips/alchemy/devboards/db1300.c
>
> c64bb5f0c26f6e Manuel Lauss 2014-08-20  742
> c64bb5f0c26f6e Manuel Lauss 2014-08-20  743  static struct wm97xx_mach_ops db1300_wm97xx_ops = {
> c64bb5f0c26f6e Manuel Lauss 2014-08-20 @744     .irq_enable     = db1300_wm97xx_irqen,
> c64bb5f0c26f6e Manuel Lauss 2014-08-20  745     .irq_gpio       = WM97XX_GPIO_3,
> c64bb5f0c26f6e Manuel Lauss 2014-08-20  746  };
> c64bb5f0c26f6e Manuel Lauss 2014-08-20  747
>
> :::::: The code at line 744 was first introduced by commit
> :::::: c64bb5f0c26f6ea791270852217b7cb28553ba76 MIPS: Alchemy: DB1300: Add touch penirq support
>
> :::::: TO: Manuel Lauss <manuel.lauss at gmail.com>
> :::::: CC: Ralf Baechle <ralf at linux-mips.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp