[PATCH 0/5] Tidy up symbol end fixup

Ian Rogers irogers at google.com
Thu Apr 7 16:04:58 PDT 2022


Fixing up more symbol ends as introduced in:
https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/
caused perf annotate to run into memory limits - every symbol holds
all the disassembled code in the annotation, and so making symbols
ends further away dramatically increased memory usage (40MB to
 >1GB). Modify the symbol end logic so that special kernel cases aren't
applied in the common case.

Minor fix to perf annotate to not stall when stderr is full.

Ian Rogers (5):
  perf annotate: Drop objdump stderr
  perf symbols: Always do architecture specific fixups
  perf symbols: Add is_kernel argument to fixup end
  perf symbol: By default only fix zero length symbols
  perf symbols: More specific architecture end fixing

 tools/perf/arch/arm64/util/machine.c   | 14 +++++++++-----
 tools/perf/arch/powerpc/util/machine.c | 10 +++++++---
 tools/perf/arch/s390/util/machine.c    | 12 ++++++++----
 tools/perf/util/annotate.c             |  1 +
 tools/perf/util/symbol-elf.c           |  2 +-
 tools/perf/util/symbol.c               | 14 ++++++++------
 tools/perf/util/symbol.h               |  4 ++--
 7 files changed, 36 insertions(+), 21 deletions(-)

-- 
2.35.1.1178.g4f1659d476-goog




More information about the linux-arm-kernel mailing list