[PATCH v3 3/3] arm64: dts: arm: add corstone1000 device tree

Rob Herring robh at kernel.org
Wed Apr 6 07:22:38 PDT 2022


On Fri, Apr 01, 2022 at 11:53:22AM +0100, Sudeep Holla wrote:
> On Thu, Mar 31, 2022 at 12:24:14PM +0100, Rui Miguel Silva wrote:
> > On Thu, Mar 31, 2022 at 11:48:54AM +0100, Sudeep Holla wrote:
> > > On Wed, Mar 30, 2022 at 02:10:53PM +0100, Rui Miguel Silva wrote:
> > > > +
> > > > +		mhu_hse1: mailbox at 1b820000 {
> > > > +			compatible = "arm,mhuv2-tx", "arm,primecell";
> > > > +			reg = <0x1b820000 0x1000>;
> > > > +			clocks = <&refclk100mhz>;
> > > > +			clock-names = "apb_pclk";
> > > > +			interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			#mbox-cells = <2>;
> > > > +			arm,mhuv2-protocols = <0 0>;
> > > > +			secure-status = "okay";     /* secure-world-only */
> > > 
> > > Please drop the above. Though I see it is in the binding, no one uses
> > > it in the kernel and I prefer not to have this.
> > 
> > the secure partitions in secure world use this mailbox to
> > doorbell the secure enclave so, after talking with Rob he suggested to
> > use this bindings to make this clear. So, I will keep this ones.
> > 
> Hi Rob,
> 
> Since this is first user of this binding(which is there for a while, but
> no users in the kernel code base), are you fine with this ? 

The general rule is 'don't put status in examples'. I think the same 
should apply here as that is outside the scope of the binding.

Rob



More information about the linux-arm-kernel mailing list