[PATCH] clk: bcm2835: Round UART input clock up
kernel test robot
lkp at intel.com
Mon Apr 4 03:59:58 PDT 2022
Hi "Ivan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.18-rc1 next-20220404]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Ivan-T-Ivanov/clk-bcm2835-Round-UART-input-clock-up/20220404-170105
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: riscv-randconfig-r042-20220404 (https://download.01.org/0day-ci/archive/20220404/202204041850.zEjvoN6Y-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/79c34b5361c9ab155da3175cfc964b67b9a06eab
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Ivan-T-Ivanov/clk-bcm2835-Round-UART-input-clock-up/20220404-170105
git checkout 79c34b5361c9ab155da3175cfc964b67b9a06eab
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/clk/bcm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clk/bcm/clk-bcm2835.c:997:15: warning: no previous prototype for 'bcm2835_clock_round' [-Wmissing-prototypes]
997 | unsigned long bcm2835_clock_round(unsigned long clk)
| ^~~~~~~~~~~~~~~~~~~
vim +/bcm2835_clock_round +997 drivers/clk/bcm/clk-bcm2835.c
996
> 997 unsigned long bcm2835_clock_round(unsigned long clk)
998 {
999 unsigned long scaler;
1000
1001 /*
1002 * If increasing a clock by less than 0.1% changes it
1003 * from ..999.. to ..000.., round up.
1004 */
1005 scaler = 1;
1006 while (scaler * 100000 < clk)
1007 scaler *= 10;
1008 if ((clk + scaler - 1) / scaler % 1000 == 0)
1009 clk = (clk / scaler + 1) * scaler;
1010
1011 return clk;
1012 }
1013
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the linux-arm-kernel
mailing list