[PATCH] fix refcount leak in mxs_get_ocotp()

cgel.zte at gmail.com cgel.zte at gmail.com
Fri Apr 1 18:33:22 PDT 2022


From: Lv Ruyi <lv.ruyi at zte.com.cn>

The of_find_compatible_node() function returns a node pointer with
refcount incremented, use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci at zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi at zte.com.cn>
---
 arch/arm/mach-mxs/mach-mxs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 25c9d184fa4c..6eb731f38727 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -98,6 +98,7 @@ static const u32 *mxs_get_ocotp(void)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,ocotp");
 	ocotp_base = of_iomap(np, 0);
+	of_node_put(np);
 	WARN_ON(!ocotp_base);
 
 	mutex_lock(&ocotp_mutex);
-- 
2.25.1




More information about the linux-arm-kernel mailing list