[PATCH 4/5] ARM: dts: BCM5301X: Retrieve gmac1 MAC address from NVRAM on Asus RT-AC88U

Rafał Miłecki rafal at milecki.pl
Fri Apr 1 03:32:37 PDT 2022


On 2022-04-01 12:20, Arınç ÜNAL wrote:
> The et1macaddr NVRAM variable contains a MAC address for gmac1 on Asus
> RT-AC88U. Add NVMEM cell for it and reference it in the gmac1 node.
> 
> The Broadcom GBit BCMA driver will issue the MAC address for 
> gmac{0,1,2}
> retrieved from et{0,1,2}mac from SPROM without this but let's 
> explicitly
> define it as mac-address on the devicetree.
> Refer to drivers/net/ethernet/broadcom/bgmac-bcma.c:147.

It doesn't matter how Linux handles that in details. You're working on
hardware binding.

Change is OK of course.

If you need to reference sth it should be
Documentation/devicetree/bindings/net/ethernet-controller.yaml


> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>

I'd drop bgmac-bcma.c reference but nevertheless:

Acked-by: Rafał Miłecki <rafal at milecki.pl>



More information about the linux-arm-kernel mailing list