[PATCH] ARM: davinci: fix unmet dependency on PINCTRL for PINCTRL_SINGLE

Julian Braha julianbraha at gmail.com
Fri Oct 29 15:07:13 PDT 2021


When ARCH_DAVINCI is enabled and PINCTRL is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
  Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
  Selected by [y]:
  - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]

This is because ARCH_DAVINCI selects PINCTRL_SINGLE
without selecting or depending on PINCTRL, despite
PINCTRL_SINGLE depending on PINCTRL.

This unmet dependency was detected by Kismet, a
static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.

Signed-off-by: Julian Braha <julianbraha at gmail.com>
---
 arch/arm/mach-davinci/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 1d3aef84287d..a9ae3ba4536c 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -9,7 +9,7 @@ menuconfig ARCH_DAVINCI
 	select PM_GENERIC_DOMAINS_OF if PM && OF
 	select REGMAP_MMIO
 	select RESET_CONTROLLER
-	select PINCTRL_SINGLE
+	imply PINCTRL_SINGLE
 
 if ARCH_DAVINCI
 
-- 
2.30.2




More information about the linux-arm-kernel mailing list