[PATCH v1 1/1] PCI: brcmstb: Use GENMASK() as __GENMASK() is for internal use only
Krzysztof Wilczyński
kw at linux.com
Wed Oct 27 03:00:16 PDT 2021
Hi Andy,
> Use GENMASK() as __GENMASK() is for internal use only.
To add, for posterity, that using __GENMASK() bypasses the
GENMASK_INPUT_CHECK() macro that adds extra validation.
> Fixes: 3baec684a531 ("PCI: brcmstb: Accommodate MSI for older chips")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 1fc7bd49a7ad..51522510c08c 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -619,7 +619,7 @@ static void brcm_msi_remove(struct brcm_pcie *pcie)
>
> static void brcm_msi_set_regs(struct brcm_msi *msi)
> {
> - u32 val = __GENMASK(31, msi->legacy_shift);
> + u32 val = GENMASK(31, msi->legacy_shift);
Thank you!
Reviewed-by: Krzysztof Wilczyński <kw at linux.com>
Krzysztof
More information about the linux-arm-kernel
mailing list