[PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up

Francesco Dolcini francesco.dolcini at toradex.com
Tue Oct 26 01:52:21 PDT 2021


On Tue, Oct 26, 2021 at 02:18:18AM +0000, Richard Zhu wrote:
> The _enabled check is used because that this regulator is optional in the HW design.
> To make the codes clean and aligned on different HW boards, the _enabled check is added.
> 
> The root cause is that the error return is not handled properly by the controller driver.
> I.MX PCIe controller doesn't support the Hot-Plug, and it would return -110 error
> when PCIe link never came up. Thus, the _probe would be failed in the end.
> The clocks/regulator usage balance should be considered by i.MX PCIe controller, that's all.
> It's not a general case, and the problem is not caused by the regulator support.

Hello Richard,
I have one curiosity on this topic. Does this works well in case the regulator
is shared? I just want to be sure that if the regulator is shared everything is working fine
even if the PCI-E link is not used or not coming up for any reason.

Francesco




More information about the linux-arm-kernel mailing list