[PATCH v3 2/2] reset: mchp: sparx5: Extend support for lan966x

Philipp Zabel p.zabel at pengutronix.de
Mon Oct 18 03:43:24 PDT 2021


On Thu, 2021-10-14 at 17:40 +0200, Horatiu Vultur wrote:
> 
> > > +      */
> > > +     err = mchp_sparx5_map_syscon(pdev, "cuphy-syscon", &ctx->cuphy_ctrl);
> > > +     if (err && err != -ENODEV)
> > > +             return err;
> > 
> > So -ENODEV should return an error if .cuphy_reg is set?
> 
> I am not sure I follow this.
> If cuphy-syscon is not set then mchp_sparx5_map_syscon will return
> -ENODEV. This can be ignored for sparx5 as this is not required.
> If cuphy-syscon is set then if mchp_sparx5_map_syscon returns an error
> then report this error.

My point was that in case of cuphy-syscon missing from the DT, the
lan966x compatible reset controller should probably throw the error
instead of ignoring it. With v4 this is not relevant any more.

regards
Philipp



More information about the linux-arm-kernel mailing list