[PATCH] ARM: imx: register reset controller from a platform driver

Philipp Zabel p.zabel at pengutronix.de
Wed Oct 6 01:11:27 PDT 2021


Hi Geert,

On Wed, 2021-10-06 at 09:23 +0200, Geert Uytterhoeven wrote:
> Hi Philipp,
> 
> On Tue, Oct 5, 2021 at 12:12 PM Philipp Zabel <p.zabel at pengutronix.de> wrote:
> > Starting with commit 6b2117ad65f1 ("of: property: fw_devlink: Add
> > support for "resets" and "pwms""), the imx-drm driver fails to load
> > due to forever dormant devlinks to the reset-controller node. This
> > node was never associated with a struct device.
> > 
> > Add a platform device to allow fw_devnode to activate the devlinks.
> > 
> > Fixes: 6b2117ad65f1 ("of: property: fw_devlink: Add support for "resets" and "pwms"")
> > Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> 
> Thanks for your patch!
> 
> Do you also need a "select RESET_CONTROLLER" somewhere for
> this to work?

Right now we have this:

  config SOC_IMX...
	select HAVE_IMX_SRC

  config HAVE_IMX_SRC
	select ARCH_HAS_RESET_CONTROLLER

  config ARCH_HAS_RESET_CONTROLLER
	bool

  config RESET_CONTROLLER
	default y if ARCH_HAS_RESET_CONTROLLER

So it is possible to manually disable RESET_CONTROLLER if the drivers
using those resets are not required.

regards
Philipp



More information about the linux-arm-kernel mailing list