[PATCH v2 1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device()

Sam Protsenko semen.protsenko at linaro.org
Tue Oct 5 05:06:55 PDT 2021


On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski
<krzysztof.kozlowski at canonical.com> wrote:
>
> soc_device_to_device() seems to be discouraged [1] so remove it in favor
> of printing info message with platform device.  This will only change
> the prefix in theh info message from "soc soc0: " to "exynos-chipid
> 10000000.chipid:".
>
> [1] https://lore.kernel.org/lkml/20191111052741.GB3176397@kroah.com/
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko at linaro.org>

>  drivers/soc/samsung/exynos-chipid.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
> index 5c1d0f97f766..dcd9a08ce706 100644
> --- a/drivers/soc/samsung/exynos-chipid.c
> +++ b/drivers/soc/samsung/exynos-chipid.c
> @@ -104,8 +104,7 @@ static int exynos_chipid_probe(struct platform_device *pdev)
>
>         platform_set_drvdata(pdev, soc_dev);
>
> -       dev_info(soc_device_to_device(soc_dev),
> -                "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
> +       dev_info(&pdev->dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
>                  soc_dev_attr->soc_id, product_id, revision);
>
>         return 0;
> --
> 2.30.2
>



More information about the linux-arm-kernel mailing list