[PATCHv4 1/3] kernel/irq: make irq_{enter, exit}() in handle_domain_irq() arch optional
Marc Zyngier
maz at kernel.org
Mon Oct 4 09:30:26 PDT 2021
On Fri, 01 Oct 2021 15:44:04 +0100,
Pingfan Liu <kernelfans at gmail.com> wrote:
>
> When an IRQ is taken, some accounting needs to be performed to enter and
> exit IRQ context around the IRQ handler. Historically arch code would
> leave this to the irqchip or core IRQ code, but these days we want this
> to happen in exception entry code, and architectures such as arm64 do
> this.
>
> Currently handle_domain_irq() performs this entry/exit accounting, and
> if used on an architecture where the entry code also does this, the
> entry/exit accounting will be performed twice per IRQ. This is
> problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle()
> depends on this happening once per IRQ, and will not detect quescent
> periods correctly, leading to stall warnings.
>
> As irqchip drivers which use handle_domain_irq() need to work on
> architectures with or without their own entry/exit accounting, this
> patch makes handle_domain_irq() conditionally perform the entry
> accounting depending on a new HAVE_ARCH_IRQENTRY Kconfig symbol that
> architectures can select if they perform this entry accounting
> themselves.
>
> For architectures which do not select the symbol. there should be no
> functional change as a result of this patch.
>
> Signed-off-by: Pingfan Liu <kernelfans at gmail.com>
> Reviewed-by: Mark Rutland <mark.rutland at arm.com>
> Cc: "Paul E. McKenney" <paulmck at kernel.org>
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Will Deacon <will at kernel.org>
> Cc: Marc Zyngier <maz at kernel.org>
> Cc: Joey Gouly <joey.gouly at arm.com>
> Cc: Sami Tolvanen <samitolvanen at google.com>
> Cc: Julien Thierry <julien.thierry at arm.com>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: Yuichi Ito <ito-yuichi at fujitsu.com>
> Cc: linux-kernel at vger.kernel.org
> To: linux-arm-kernel at lists.infradead.org
Reviewed-by: Marc Zyngier <maz at kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
More information about the linux-arm-kernel
mailing list