[PATCH 1/2] firmware: arm_ffa: Add missing remove callback to ffa_bus_type

Jens Wiklander jens.wiklander at linaro.org
Mon Oct 4 03:09:10 PDT 2021


On Fri, Sep 24, 2021 at 11:29 AM Sudeep Holla <sudeep.holla at arm.com> wrote:
>
> Currently the arm_ffa firmware driver can be built as module and hence
> all the users of FFA driver. If any driver on the ffa bus is removed or
> unregistered, the remove callback on all the device bound to the driver
> being removed should be callback. For that to happen, we must register
> a remove callback on the ffa_bus which is currently missing. This results
> in the probe getting called again without the previous remove callback
> on a device which may result in kernel crash.
>
> Fix the issue by registering the remove callback on the FFA bus.
>
> Fixes: e781858488b9 ("firmware: arm_ffa: Add initial FFA bus support for device enumeration")
> Reported-by: Jens Wiklander <jens.wiklander at linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
> ---
>  drivers/firmware/arm_ffa/bus.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Tested-by: Jens Wiklander <jens.wiklander at linaro.org>



More information about the linux-arm-kernel mailing list