[PATCH v2 09/12] ARM: percpu: add SMP_ON_UP support

Ard Biesheuvel ardb at kernel.org
Tue Nov 30 07:45:09 PST 2021


On Tue, 30 Nov 2021 at 16:12, Russell King (Oracle)
<linux at armlinux.org.uk> wrote:
>
> On Tue, Nov 30, 2021 at 01:58:58PM +0100, Ard Biesheuvel wrote:
> > diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h
> > index e2fcb3cfd3de..ff8f0829e041 100644
> > --- a/arch/arm/include/asm/percpu.h
> > +++ b/arch/arm/include/asm/percpu.h
> > @@ -5,15 +5,22 @@
> >  #ifndef _ASM_ARM_PERCPU_H_
> >  #define _ASM_ARM_PERCPU_H_
> >
> > +#include <asm/insn.h>
> > +
> >  register unsigned long current_stack_pointer asm ("sp");
> >
> >  /*
> >   * Same as asm-generic/percpu.h, except that we store the per cpu offset
> >   * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7
> >   */
> > -#if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6)
> > +#ifdef CONFIG_SMP
> > +extern unsigned int smp_on_up;
>
> I would much rather we kept this hidden from global view by placing it
> inside the set_my_cpu_offset() body.
>

Good point, I'll change that.



More information about the linux-arm-kernel mailing list