[PATCH v4 04/13] mtd: spi-nor: core: Introduce flash_info mfr_flags

Michael Walle michael at walle.cc
Mon Nov 22 10:34:08 PST 2021


Am 2021-11-22 10:50, schrieb Tudor Ambarus:
> Used in the manufacturer fixup hooks to differentiate support
> between flashes of the same manufacturer. Not used in the
> SPI NOR core.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus at microchip.com>

Nice!
Reviewed-by: Michael Walle <michael at walle.cc>

> @@ -58,28 +61,46 @@ static const struct spi_nor_fixups sst26vf_fixups = 
> {
>  static const struct flash_info sst_parts[] = {
>  	/* SST -- large erase sizes are "overlays", "sectors" are 4K */
>  	{ "sst25vf040b", INFO(0xbf258d, 0, 64 * 1024,  8,
> -			      SECT_4K | SST_WRITE | SPI_NOR_HAS_LOCK | 
> SPI_NOR_SWP_IS_VOLATILE) },
> +			      SECT_4K | SPI_NOR_HAS_LOCK |
> +			      SPI_NOR_SWP_IS_VOLATILE)
> +		MFR_FLAGS(SST_WRITE) },

Looks a bit odd, but I'm fine with that. Does checkpatch.pl complain, 
though?

-michael



More information about the linux-arm-kernel mailing list