[PATCH v2 2/2] memory: fsl_ifc: populate child devices without relying on simple-bus

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Tue Nov 16 02:35:09 PST 2021


On 15/10/2021 02:57, Li Yang wrote:
> After we update the binding to not use simple-bus compatible for the
> controller, we need the driver to populate the child devices explicitly.
> 
> Signed-off-by: Li Yang <leoyang.li at nxp.com>
> ---
>  drivers/memory/fsl_ifc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> index d062c2f8250f..ef2092fa90d9 100644
> --- a/drivers/memory/fsl_ifc.c
> +++ b/drivers/memory/fsl_ifc.c
> @@ -88,6 +88,7 @@ static int fsl_ifc_ctrl_remove(struct platform_device *dev)
>  {
>  	struct fsl_ifc_ctrl *ctrl = dev_get_drvdata(&dev->dev);
>  
> +	of_platform_depopulate(&dev->dev);
>  	free_irq(ctrl->nand_irq, ctrl);
>  	free_irq(ctrl->irq, ctrl);
>  
> @@ -285,6 +286,12 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
>  		}
>  	}
>  
> +	/* legacy dts may still use "simple-bus" compatible */
> +	ret = of_platform_populate(dev->dev.of_node, NULL, NULL,
> +					&dev->dev);
> +	if (ret)
> +		goto err_nandirq;
> +

This one does not apply. Please rebase.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list