[PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers

[Joel Stanley]

On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo at intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
>
> Hello all,
>
> This series is for appliying below fix to all Aspped LPC sub drivers.
> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>
> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
> can be registered ahead of lpc-ctrl depends on each system configuration and
> this difference introduces that LPC can be enabled without heart beating of
> LCLK so it causes improper handling on host interrupts when the host sends
> interrupts in that time frame. Then kernel eventually forcibly disables the
> interrupt with dumping stack and printing a 'nobody cared this irq' message
> out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK individually
> so this patch adds clock control logic into the remaining Aspeed LPC sub
> drivers.

Thanks for sending this out!

This will resolve a few of the issues we have in the issue tracker:

https://github.com/openbmc/linux/issues/210
https://github.com/openbmc/linux/issues/130

The patches look good to me. I think you've just missed Corey's PR for
v5.16, but I will stick them in the openbmc tree once they've had a
review.

Cheers,

Joel

>
> Please review this series.
>
> Thanks,
> Jae
>
> Jae Hyun Yoo (4):
>   ARM: dts: aspeed: add LCLK setting into LPC IBT node
>   ipmi: bt: add clock control logic
>   ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
>   ipmi: kcs_bmc_aspeed: add clock control logic
>
>  arch/arm/boot/dts/aspeed-g4.dtsi   |  1 +
>  arch/arm/boot/dts/aspeed-g5.dtsi   |  5 +++++
>  arch/arm/boot/dts/aspeed-g6.dtsi   |  5 +++++
>  drivers/char/ipmi/bt-bmc.c         | 24 ++++++++++++++++++++++-
>  drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
>  5 files changed, 61 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
>