[PATCH] dt-bindings: i2c: brcm,iproc-i2c: convert to the json-schema

Rafał Miłecki rafal at milecki.pl
Fri May 28 02:37:16 PDT 2021


On 28.05.2021 11:23, Wolfram Sang wrote:
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.example.dt.yaml:0:0: /example-0/i2c at 18008000/wm8750 at 1a: failed to match any schema with compatible: ['wlf,wm8750']
> 
> A generic question:
> 
> So sound/wm8750.txt was not converted yet. However, if this conversion
> is fine otherwise, I'd vote to apply it nonetheless because it is one
> conversion less to do then. Alternatively, we could change the example
> to include a simple EEPROM which has an already converted binding doc.
> 
> What is the procedure here?
> 
> All the best and thanks for your work!

Let me try to answer this based on the discussion in the:
[PATCH V3 robh dt/next] dt-bindings: mfd: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210519184041.563-1-zajec5@gmail.com/


Rob has stated he doesn't want maintainers to apply bindings that
introduce documentation warnings/errors:
https://patchwork.ozlabs.org/comment/2687693/

Lee Jones as MFD maintainer says it's wrong:
https://patchwork.ozlabs.org/comment/2687847/


I've already got wm8750 YAML binding queued for the 5.14, see linux-next:
ASoC: wm8750: convert to the json-schema
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=11480dbfe1d59eaa6382864acc476e7621b1da4c

Personally I think it's a bit too paranoid to reject such a patch if we
have a proof that its dependency is already part of the linux-next. If
you agree with Rob however I'll just resubmit this very same patch once
Rob updates his tree to the 5.14-rc1 (once it's released). I still think
it just makes the whole process take unnecessarily long.



More information about the linux-arm-kernel mailing list