[PATCH 1/1] PCI: dwc/imx6: Remove redundant error printing in imx6_pcie_probe()
Richard Zhu
hongxing.zhu at nxp.com
Fri May 28 00:54:07 PDT 2021
Hi Zhen Lei:
Thanks.
> Subject: [PATCH 1/1] PCI: dwc/imx6: Remove redundant error printing in
> imx6_pcie_probe()
>
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error information
> contains the device name, failure cause, and possibly resource information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
Acked-by: Richard Zhu <hongxing.zhu at nxp.com>
Best Regards
Richard
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 0cf1333c044032f..035fb622cafafcd 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1002,10 +1002,8 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
> return ret;
> }
> imx6_pcie->phy_base = devm_ioremap_resource(dev, &res);
> - if (IS_ERR(imx6_pcie->phy_base)) {
> - dev_err(dev, "Unable to map PCIe PHY\n");
> + if (IS_ERR(imx6_pcie->phy_base))
> return PTR_ERR(imx6_pcie->phy_base);
> - }
> }
>
> dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.26.0.106.g9fadedd
>
More information about the linux-arm-kernel
mailing list