[PATCH v2] dt-bindings: net: Convert MDIO mux bindings to DT schema

Rob Herring robh at kernel.org
Wed May 26 13:48:54 PDT 2021


On Wed, May 26, 2021 at 1:51 PM Andrew Lunn <andrew at lunn.ch> wrote:
>
> On Wed, May 26, 2021 at 01:14:11PM -0500, Rob Herring wrote:
> > Convert the common MDIO mux bindings to DT schema.
> >
> > Drop the example from mdio-mux.yaml as mdio-mux-gpio.yaml has the same one.
> >
> > Cc: "David S. Miller" <davem at davemloft.net>
> > Cc: Jakub Kicinski <kuba at kernel.org>
> > Cc: Ray Jui <rjui at broadcom.com>
> > Cc: Scott Branden <sbranden at broadcom.com>
> > Cc: bcm-kernel-feedback-list at broadcom.com
> > Cc: Andrew Lunn <andrew at lunn.ch>
> > Cc: Heiner Kallweit <hkallweit1 at gmail.com>
> > Cc: Russell King <linux at armlinux.org.uk>
> > Cc: netdev at vger.kernel.org
> > Cc: linux-arm-kernel at lists.infradead.org
> > Signed-off-by: Rob Herring <robh at kernel.org>
>
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
>
> > +        mdio at 2 {  // Slot 2 XAUI (FM1)
> > +            reg = <2>;
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            ethernet-phy at 4 {
> > +                compatible = "ethernet-phy-ieee802.3-c45";
> > +                reg = <0>;
>
> reg should really be 4 here. The same error existed in the .txt

Will fixup.

> version. I guess the examples are never actually verified using the
> yaml?

They are verified in general, but for this specific check it is dtc
that does it and only for bus types that it knows about. MDIO isn't
one of them.

Rob



More information about the linux-arm-kernel mailing list