[PATCH V3 robh dt/next] dt-bindings: mfd: add Broadcom CRU

[Lee Jones]

On Fri, 21 May 2021, Rob Herring wrote:

> On Fri, May 21, 2021 at 2:31 AM Lee Jones <lee.jones at linaro.org> wrote:
> >
> > On Fri, 21 May 2021, Rafał Miłecki wrote:
> >
> > > On 21.05.2021 09:12, Lee Jones wrote:
> > > > On Thu, 20 May 2021, Rob Herring wrote:
> > > >
> > > > > On Wed, May 19, 2021 at 1:40 PM Rafał Miłecki <zajec5 at gmail.com> wrote:
> > > > > >
> > > > > > From: Rafał Miłecki <rafal at milecki.pl>
> > > > > >
> > > > > > CRU is a block used in e.g. Northstar devices. It can be seen in the
> > > > > > bcm5301x.dtsi and this binding documents its proper usage.
> > > > > >
> > > > > > Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
> > > > > > Reviewed-by: Rob Herring <robh at kernel.org>
> > > > > > ---
> > > > > > Rob: would you take this patch through your dt/next?
> > > > >
> > > > > I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is
> > > > > already upstream. For ac5f8197d15c, I could get a stable branch from
> > > > > Linus, but I can't take some random github branch. Even if I got a
> > > > > stable branch for that, that's a lot of extra work for me for 1 patch
> > > > > compared to waiting til next cycle.
> > > > >
> > > > > My suggestion is get a stable branch/tag from Linus, merge that into
> > > > > the Broadcom branch and then apply this patch. Though really, Linus
> > > > > needed to know the dependency when applying the patch if he doesn't
> > > > > rebase his tree. (I realize the dependency probably happened because
> > > > > of the review).
> > > > >
> > > > > >
> > > > > > V2: Use complete binding & change additionalProperties to false
> > > > > > V3: Use clock-controller@ for clocks
> > > > > >
> > > > > > NOTICE: this patch is based on top of the linux-next as it requires:
> > > > > > ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema")
> > > > > > 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema")
> > > > > > AND merged git at github.com:Broadcom/stblinux.git devicetree/next as it requires:
> > > > > > 8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")
> > > > > >
> > > > > > This is reworked version of the
> > > > > > [PATCH robh next] dt-bindings: bus: add Broadcom CRU
> > > > > > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210309142241.16259-1-zajec5@gmail.com/
> > > > > > ---
> > > > > >   .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
> > > > > >   1 file changed, 86 insertions(+)
> > > > > >   create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
> > > >
> > > > What's the dependency here?  It's a new file that doesn't reference anything.
> > >
> > > Without dependencies it will cause warnings for those running "dt_binding_check".
> >
> > No one runs that, it's full of warnings. ;)
> 
> That's dtbs_check on dts files which is full of warnings.
> dt_binding_check for the schema does not have warnings (well, there's
> a couple typically because either the bindings aren't reviewed or the
> dependencies are ignored).
> 
> > > I didn't find it critical so I thought Rob can take in on a promise of
> > > what is queued for the next release. It appears Rob has more strict
> > > rules so I'll just have to wait for stuff to land in Linus's tree :)
> 
> I care less if other trees break as long as linux-next doesn't.
> 
> > Rob isn't the one taking the patch. :D
> >
> > I'll apply it in a few days, unless Rob shouts real-loud!
> 
> I've said it before, MFD and their child bindings need to be applied
> in 1 tree. If you can't make that happen, then don't apply binding
> patches.

I'm not aware of MFD patches applied anywhere else.

AFAIK, they all come through me.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog