[PATCH] arm64: Make ARCH_DMA_MINALIGN configurable

Arnd Bergmann arnd at arndb.de
Mon May 17 06:35:39 PDT 2021


On Mon, May 17, 2021 at 2:01 PM Ard Biesheuvel <ardb at kernel.org> wrote:
> On Mon, 17 May 2021 at 13:06, Catalin Marinas <catalin.marinas at arm.com> wrote:
> > On Mon, May 17, 2021 at 09:43:32AM +0200, Vincent Whitchurch wrote:
> >
> > Another option I recall discussing with Arnd about two years ago was to
> > start with the default 128 at boot but add the smaller slab caches
> > later, once we have more information. This can be just another 64 byte
> > cache or even go all the way down to 8 byte if all the devices are
> > cache coherent.
> >
>
> ARCH_SLAB_MINALIGN is also used to statically align (members of)
> struct types, so doing this at runtime is going to have limited
> effect.
>
> If a) ThunderX is the only platform we care about (do we?) that has
> 128 byte cachelines, and b) DMA is cache coherent on such platforms,
> couldn't we separate ARCH_SLAB_MINALIGN from ARCH_DMA_MINALIGN? I.e.,
> set the first to 64 and keep the second at 128?

What is the purpose of ARCH_DMA_MINALIGN then? If it's cache
coherent, does DMA buffer still need to be aligned to the cache line
size?

Are you sure that ThunderX is the only one with cache lines this large?

       Arnd



More information about the linux-arm-kernel mailing list