[PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe()
Alexandre TORGUE
alexandre.torgue at foss.st.com
Wed May 12 05:03:15 PDT 2021
On 5/11/21 12:04 PM, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
> ---
> drivers/irqchip/irq-stm32-exti.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index b9db90c4aa566f1..4704f2ee5797a1d 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> host_data->base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(host_data->base)) {
> - dev_err(dev, "Unable to map registers\n");
> + if (IS_ERR(host_data->base))
> return PTR_ERR(host_data->base);
> - }
>
> for (i = 0; i < drv_data->bank_nr; i++)
> stm32_exti_chip_init(host_data, i, np);
>
Acked-by: Alexandre TORGUE <alexandre.torgue at foss.st.com>
thanks
alex
More information about the linux-arm-kernel
mailing list