[arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'

[Marc Zyngier]

On 2021-03-31 05:37, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> kvm-arm64/ptp
> head:   b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
> commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64:
> Probe for the presence of KVM hypervisor
> config: arm64-randconfig-m031-20210330 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp at intel.com>
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> smatch warnings:
> drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available()
> warn: signedness bug returning '(-22)'
> 
> vim +46 drivers/firmware/smccc/kvm_guest.c
> 
> fa591eac2e1ffd Will Deacon 2020-12-09  43  bool
> kvm_arm_hyp_service_available(u32 func_id)
>                                            ^^^^
> 
> fa591eac2e1ffd Will Deacon 2020-12-09  44  {
> fa591eac2e1ffd Will Deacon 2020-12-09  45  	if (func_id >=
> ARM_SMCCC_KVM_NUM_FUNCS)
> fa591eac2e1ffd Will Deacon 2020-12-09 @46  		return -EINVAL;
>                                                         ^^^^^^^^^^^^^^^
> This counts as true.

Nice catch. Now fixed. Thanks for the heads up.

         M.
-- 
Jazz is not dead. It just smells funny...