[PATCH] clk: zynqmp: Enable the driver if ZYNQMP_FIRMWARE is selected
Punit Agrawal
punit1.agrawal at toshiba.co.jp
Mon Mar 22 05:00:01 GMT 2021
Punit Agrawal <punit1.agrawal at toshiba.co.jp> writes:
> Hi Michal,
>
> Michal Simek <michal.simek at xilinx.com> writes:
>
>> On 3/16/21 10:05 AM, Punit Agrawal wrote:
>>> When booting the kernel on zynqmp based platforms such as Ultra96v2,
>>> peripheral drivers such as that for the sdcard depend on the presense
>>> of clocks.
>>>
>>> Enable the clock driver if it's dependencies are compiled to avoid
>>> building an unbootable kernel.
>>>
>>> Signed-off-by: Punit Agrawal <punit1.agrawal at toshiba.co.jp>
>>> ---
>>> drivers/clk/zynqmp/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
>>> index 17086059be8b..14e4f5c55525 100644
>>> --- a/drivers/clk/zynqmp/Kconfig
>>> +++ b/drivers/clk/zynqmp/Kconfig
>>> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
>>> bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
>>> depends on ARCH_ZYNQMP || COMPILE_TEST
>>> depends on ZYNQMP_FIRMWARE
>>> + default ZYNQMP_FIRMWARE
>>> help
>>> Support for the Zynqmp Ultrascale clock controller.
>>> It has a dependency on the PMU firmware.
>>>
>>
>> I am fine with it but I think we should fix also that depends on
>> ARCH_ZYNQMP. ZYNQMP_FIRMWARE already depends on ARCH_ZYNQMP that's why
>> it is redundant here.
>
> Sure - let me send an update converting the depends to a default.
Ah I misunderstood what you were suggesting.
I'll add a patch on top to drop the ARCH_ZYNQMP dependency (and move
COMPILE_TEST to ZYNQMP_FIRMWARE).
Thanks,
Punit
[...]
More information about the linux-arm-kernel
mailing list