[PATCH 1/5] arm64: vdso: Use GFP_KERNEL for allocating compat vdso and signal pages

[Vincenzo Frascino]

On 3/18/21 5:07 PM, Will Deacon wrote:
> There's no need to allocate the compat vDSO and signal pages using
> GFP_ATOMIC allocations, so use GFP_KERNEL instead.
> 
> Signed-off-by: Will Deacon <will at kernel.org>

Nit: We could explain why GFP_KERNEL is sufficient in the commit message.

Otherwise:

Reviewed-by: Vincenzo Frascino <vincenzo.frascino at arm.com>

> ---
>  arch/arm64/kernel/vdso.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> index cee5d04ea9ad..2d057a4dc787 100644
> --- a/arch/arm64/kernel/vdso.c
> +++ b/arch/arm64/kernel/vdso.c
> @@ -299,7 +299,7 @@ static int aarch32_alloc_kuser_vdso_page(void)
>  	if (!IS_ENABLED(CONFIG_KUSER_HELPERS))
>  		return 0;
>  
> -	vdso_page = get_zeroed_page(GFP_ATOMIC);
> +	vdso_page = get_zeroed_page(GFP_KERNEL);
>  	if (!vdso_page)
>  		return -ENOMEM;
>  
> @@ -316,7 +316,7 @@ static int aarch32_alloc_sigpage(void)
>  	int sigret_sz = __aarch32_sigret_code_end - __aarch32_sigret_code_start;
>  	unsigned long sigpage;
>  
> -	sigpage = get_zeroed_page(GFP_ATOMIC);
> +	sigpage = get_zeroed_page(GFP_KERNEL);
>  	if (!sigpage)
>  		return -ENOMEM;
>  
> 

-- 
Regards,
Vincenzo