[PATCH v8 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP
Álvaro Fernández Rojas
noltari at gmail.com
Wed Mar 17 14:37:42 GMT 2021
The current code doesn't check if GPIOLIB_IRQCHIP is enabled, which results in
a compilation error when trying to build gpio-regmap if CONFIG_GPIOLIB_IRQCHIP
isn't enabled.
Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()")
Suggested-by: Michael Walle <michael at walle.cc>
Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com>
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
Reviewed-by: Michael Walle <michael at walle.cc>
---
v8: no changes
v7: no changes
v6: no changes
v5: add missing Suggested-by tag
v4: add patch (fix include instead of gpio-regmap.c)
include/linux/gpio/driver.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 286de0520574..ecf0032a0995 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -624,8 +624,17 @@ void gpiochip_irq_domain_deactivate(struct irq_domain *domain,
bool gpiochip_irqchip_irq_valid(const struct gpio_chip *gc,
unsigned int offset);
+#ifdef CONFIG_GPIOLIB_IRQCHIP
int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
struct irq_domain *domain);
+#else
+static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
+ struct irq_domain *domain)
+{
+ WARN_ON(1);
+ return -EINVAL;
+}
+#endif
int gpiochip_generic_request(struct gpio_chip *gc, unsigned int offset);
void gpiochip_generic_free(struct gpio_chip *gc, unsigned int offset);
--
2.20.1
More information about the linux-arm-kernel
mailing list