[PATCH 1/9] watchdog: of_xilinx_wdt: Add comment to spinlock
Guenter Roeck
linux at roeck-us.net
Tue Mar 16 02:21:48 GMT 2021
On 3/15/21 3:46 AM, Srinivas Neeli wrote:
> From: Srinivas Goud <srinivas.goud at xilinx.com>
>
> Based on checkpatch every spinlock should be documented.
> The patch is fixing this issue:
> ./scripts/checkpatch.pl --strict -f drivers/watchdog/of_xilinx_wdt.c
> CHECK: spinlock_t definition without comment
> + spinlock_t spinlock;
>
> Signed-off-by: Srinivas Goud <srinivas.goud at xilinx.com>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> Signed-off-by: Srinivas Neeli <srinivas.neeli at xilinx.com>
Reviewed-by: Guenter Roeck <linux at roeck-us.net>
> ---
> drivers/watchdog/of_xilinx_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 7fe4f7c3f7ce..00549164b3d7 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -40,7 +40,7 @@
> struct xwdt_device {
> void __iomem *base;
> u32 wdt_interval;
> - spinlock_t spinlock;
> + spinlock_t spinlock; /* spinlock for register handling */
> struct watchdog_device xilinx_wdt_wdd;
> struct clk *clk;
> };
>
More information about the linux-arm-kernel
mailing list