[PATCH] drm/exynos/decon5433: Clean up GPIO includes

[Inki Dae]

21. 3. 15. 오후 3:45에 tiantao (H) 이(가) 쓴 글:
> 
> 在 2021/3/15 14:35, Inki Dae 写道:
>> Hi Tian Tao,
>>
>> 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
>>> remove the legacy GPIO headers <linux/of_gpio.h> but what it really
>>> uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
>>> referenced.
>> This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion?
> 
> Thanks for helping to review patch,I've posted a new patch to fix this problem  If you can give me review-by, I can help push to drm-misc.

I can merge this patch and other one[1] to exynos drm tree after review, and will have a pull-request soon so no need to land to drm-misc tree.
Let's not bother Daniel. :)

[1] https://patchwork.kernel.org/project/dri-devel/patch/1615549385-33784-1-git-send-email-tiantao6@hisilicon.com/

Thanks,
Inki Dae

> 
> Subject: [PATCH] drm/exynos/decon5433: Remove the unused include statements
> 
> This driver doesn't reference of_gpio.h, so drop it.
> 
> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>
> ---
>  drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 1f79bc2..1510e4e 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -13,7 +13,6 @@
>  #include <linux/irq.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/regmap.h>
> 
>>
>> Thanks,
>> Inki Dae
>>
>>> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>
>>> ---
>>>   drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>>> index 1f79bc2..9fc51a6 100644
>>> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>>> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>>> @@ -11,9 +11,9 @@
>>>   #include <linux/component.h>
>>>   #include <linux/iopoll.h>
>>>   #include <linux/irq.h>
>>> +#include <linux/gpio/consumer.h>
>>>   #include <linux/mfd/syscon.h>
>>>   #include <linux/of_device.h>
>>> -#include <linux/of_gpio.h>
>>>   #include <linux/platform_device.h>
>>>   #include <linux/pm_runtime.h>
>>>   #include <linux/regmap.h>
>>>
>> .
>>
> 
>