[PATCH] ARM: dts: stm32: Fill GPIO line names on AV96
Christoph Niedermaier
cniedermaier at dh-electronics.com
Fri Mar 12 15:17:43 GMT 2021
From: Marek Vasut [mailto:marex at denx.de]
Sent: Thursday, August 6, 2020 9:30 AM
> On 8/6/20 9:09 AM, Christoph Niedermaier wrote:
>> From: Marek Vasut <marex at denx.de>
>> Sent: Friday, July 24, 2020 12:16 PM
>>>
>>> Fill in the custom GPIO line names used by DH.
>>>
>> [...]
>>> +&gpioa {
>>> + gpio-line-names = "", "", "", "",
>>> + "", "", "", "",
>>> + "", "", "", "DH-GPIO-K",
>>> + "DH-GPIO-I", "", "DH-GPIO-A", "";
>>> +};
>>> +
>> [...]
>>
>> We have been using the GPIO names at DH electronics for some time and also
>> on other SOMs, but have not yet streamed them. We started with the naming
>> only with a capital letter "A-W" since then without problems. To avoid a
>> hard cut or patching for us and our customers it would be good if we could
>> use the same naming in the mainline kernel as well. Marek, we would be
>> happy if you would adopt our valued GPIO naming in your patch.
>
> My counter-argument to this is that the naming should be unique and
> provide a hint where those GPIO lines come from, so maybe even DH-GPIO-n
> should rather be DHCOM-n . I can't say I'm particularly fond of the
> plain 'n' naming of GPIO lines, because then the GPIO label (and e.g.
> listing in libgpiod tools) does not give any hint what the GPIO is or
> where it comes from. Also, I worry a plain 'n' naming might clash with
> other GPIO IPs easily, while a more unique name can not.
Hello Marek,
after an internal discussion, we decided the following:
Could you update the patch for the Avenger96 to the GPIO naming "AV96-n".
Moreover for the SOM layer (stm32mp15xx-dhcom-som.dtsi) we would prefer
"DHCOM-n". It would be nice if you could create a patch for it.
Regards,
Christoph
More information about the linux-arm-kernel
mailing list