[RFT PATCH v3 06/27] dt-bindings: timer: arm,arch_timer: Add interrupt-names support
Rob Herring
robh at kernel.org
Mon Mar 8 20:38:41 GMT 2021
On Fri, Mar 05, 2021 at 06:38:41AM +0900, Hector Martin wrote:
> Not all platforms provide the same set of timers/interrupts, and Linux
> only needs one (plus kvm/guest ones); some platforms are working around
> this by using dummy fake interrupts. Implementing interrupt-names allows
> the devicetree to specify an arbitrary set of available interrupts, so
> the timer code can pick the right one.
>
> This also adds the hyp-virt timer/interrupt, which was previously not
> expressed in the fixed 4-interrupt form.
>
> Signed-off-by: Hector Martin <marcan at marcan.st>
> ---
> .../devicetree/bindings/timer/arm,arch_timer.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
> index 2c75105c1398..ebe9b0bebe41 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
> @@ -34,11 +34,25 @@ properties:
> - arm,armv8-timer
>
> interrupts:
> + minItems: 1
> + maxItems: 5
> items:
> - description: secure timer irq
> - description: non-secure timer irq
> - description: virtual timer irq
> - description: hypervisor timer irq
> + - description: hypervisor virtual timer irq
> +
> + interrupt-names:
> + minItems: 1
> + maxItems: 5
> + items:
> + enum:
> + - phys-secure
> + - phys
> + - virt
> + - hyp-phys
> + - hyp-virt
phys-secure and hyp-phys is not very consistent. secure-phys or sec-phys
instead?
This allows any order which is not ideal (unfortunately json-schema
doesn't have a way to define order with optional entries in the middle).
How many possible combinations are there which make sense? If that's a
reasonable number, I'd rather see them listed out.
Rob
More information about the linux-arm-kernel
mailing list