[PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings
Shawn Guo
shawnguo at kernel.org
Sun Mar 7 01:31:46 GMT 2021
On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote:
> Remove the unnecessary #address-cells/#size-cells and rename the node
> names to fix the following W=1 dtc warnings:
>
> arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button at 20: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button at 21: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
> arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
> index 333c306aa946..e6e9721ceea2 100644
> --- a/arch/arm/boot/dts/imx6dl-plybas.dts
> +++ b/arch/arm/boot/dts/imx6dl-plybas.dts
> @@ -19,17 +19,15 @@ chosen {
>
> gpio_keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> autorepeat;
>
> - button at 20 {
> + start-button {
I prefer name style like button-xxx.
Shawn
> label = "START";
> linux,code = <31>;
> gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> };
>
> - button at 21 {
> + clean-button {
> label = "CLEAN";
> linux,code = <46>;
> gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> --
> 2.25.1
>
More information about the linux-arm-kernel
mailing list