[PATCH 1/2] ARM: dts: imx7d-mba7: Remove unsupported property

Matthias Schiffer matthias.schiffer at ew.tq-group.com
Wed Mar 3 09:38:08 GMT 2021


On Tue, 2021-03-02 at 11:53 -0300, Fabio Estevam wrote:
> 'disable-gpio' is not a valid property according to
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt.
> 
> Remove the unsupported property.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Reviewed-by: Matthias Schiffer <matthias.schiffer at ew.tq-group.com>


This is a remnant of linux-imx, which supports the property. On the
MBa7x (and likely other boards in linux-imx that use this), the GPIO is
connected to mPCIe pin 20 (wireless_disable#). Is there an intended way
to control this pin, or should it just be left unconfigured or hogged?

power-on-gpio seems to be obsolete too, I can't even find it in current
linux-imx, except for one other i.MX7D-based DTS. I can send a patch to
remove that as well, but it might take a while until I get to it.


> ---
>  arch/arm/boot/dts/imx7d-mba7.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-mba7.dts b/arch/arm/boot/dts/imx7d-mba7.dts
> index 5ef86de53013..ebdf9b8efeb3 100644
> --- a/arch/arm/boot/dts/imx7d-mba7.dts
> +++ b/arch/arm/boot/dts/imx7d-mba7.dts
> @@ -99,7 +99,6 @@ &pcie {
>  	/* probe deferral not supported */
>  	/* pcie-bus-supply = <&reg_mpcie_1v5>; */
>  	reset-gpio = <&gpio5 12 GPIO_ACTIVE_LOW>;
> -	disable-gpio = <&gpio2 29 GPIO_ACTIVE_LOW>;
>  	power-on-gpio = <&gpio2 30 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };




More information about the linux-arm-kernel mailing list