[PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Robin Murphy
robin.murphy at arm.com
Tue Jun 15 11:08:34 PDT 2021
On 2021-06-15 19:01, Marek Szyprowski wrote:
> Hi,
>
> On 03.06.2021 18:46, Thierry Reding wrote:
>> From: Thierry Reding <treding at nvidia.com>
>>
>> Implement a ->probe_finalize() callback that can be used by vendor
>> implementations to perform extra programming necessary after devices
>> have been attached to the SMMU.
>>
>> Signed-off-by: Thierry Reding <treding at nvidia.com>
>
> This patch landed recently in linux-next as commit 0d97174aeadf
> ("iommu/arm-smmu: Implement ->probe_finalize()"). It causes the
> following issue on ARM Juno R1 board:
[...]
>> +static void arm_smmu_probe_finalize(struct device *dev)
>> +{
>> + struct arm_smmu_master_cfg *cfg;
>> + struct arm_smmu_device *smmu;
>> +
>> + cfg = dev_iommu_priv_get(dev);
>> + smmu = cfg->smmu;
>> +
>> + if (smmu->impl->probe_finalize)
Oops, indeed that needs to check smmu->impl first.
Robin.
>> + smmu->impl->probe_finalize(smmu, dev);
>> +}
>> +
More information about the linux-arm-kernel
mailing list