[PATCH] arm64/sve: Delay freeing memory in fpsimd_flush_thread()

Sebastian Andrzej Siewior bigeasy at linutronix.de
Thu Jul 29 07:39:04 PDT 2021


On 2021-07-29 15:26:16 [+0100], Mark Brown wrote:
> On Thu, Jul 29, 2021 at 12:52:14PM +0200, Sebastian Andrzej Siewior wrote:
> 
> > +static void *sve_free_atomic(struct task_struct *task)
> > +{
> > +	void *sve_state = task->thread.sve_state;
> > +
> > +	WARN_ON(test_tsk_thread_flag(task, TIF_SVE));
> > +
> > +	task->thread.sve_state = NULL;
> > +	return sve_state;
> > +}
> 
> This has exactly one caller - why not just inline it there?  It'd
> probably make it easier to follow what's going on.

In case someone makes changes to the non-atomic version which should
also happen here. But I can inline it.

Sebastian



More information about the linux-arm-kernel mailing list