Re: [PATCH 08/54] dt-bindings: bluetooth: realtek: Add missing max-speed

Alistair alistair at alistair23.me
Fri Jul 23 15:56:02 PDT 2021


On Thu, Jul 22, 2021, at 12:03 AM, Maxime Ripard wrote:
> additionalProperties prevent any property not explicitly defined in the
> binding to be used. Yet, some serial properties like max-speed are valid
> and validated through the serial/serial.yaml binding.
> 
> Even though the ideal solution would be to use unevaluatedProperties
> instead, it's not pratical due to the way the bus bindings have been
> described. Let's add max-speed to remove the warning.
> 
> Cc: Alistair Francis <alistair at alistair23.me>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Jakub Kicinski <kuba at kernel.org>
> Cc: netdev at vger.kernel.org
> Cc: Vasily Khoruzhick <anarsoul at gmail.com>
> Signed-off-by: Maxime Ripard <maxime at cerno.tech>

Reviewed-by: Alistair Francis <alistair at alistair23.me>

Alistair

> ---
> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> index 4f485df69ac3..deae94ef54b8 100644
> --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> @@ -34,6 +34,8 @@ properties:
>      maxItems: 1
>      description: GPIO specifier, used to wakeup the host processor
>  
> +  max-speed: true
> +
> required:
>    - compatible
>  
> -- 
> 2.31.1
> 
> 



More information about the linux-arm-kernel mailing list