[boot-wrapper PATCH v3 3/8] aarch64: Remove the redundant setup_stack

Mark Rutland mark.rutland at arm.com
Thu Jul 22 03:41:24 PDT 2021


On Tue, May 25, 2021 at 02:25:04PM +0800, Jaxson Han wrote:
> Since we already have set up a stack above, there is no need to do it
> again.
> Also, in fact it's a bug: setup_stack expects the logical CPU ID in
> w0, and here we always call it with w0 being 1.
> 
> Signed-off-by: Jaxson Han <jaxson.han at arm.com>
> Reviewed-by: Andre Przywara <andre.przywara at arm.com>

Since this is a bug-fix, I've cherry-picked this before all the other
patches.

Thanks,
Mark.

> ---
>  arch/aarch64/boot.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S
> index 1a5da35..1cdeb1b 100644
> --- a/arch/aarch64/boot.S
> +++ b/arch/aarch64/boot.S
> @@ -39,7 +39,6 @@ _start:
>  	ldr	x1, =flag_keep_el
>  	str	w0, [x1]
>  
> -	bl	setup_stack
>  	b	start_keep_el
>  
>  	/*
> -- 
> 2.25.1
> 



More information about the linux-arm-kernel mailing list