[PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile

Joakim Zhang qiangqing.zhang at nxp.com
Thu Jul 15 19:04:56 PDT 2021


Hi Mac, Aisheng,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl at pengutronix.de>
> Sent: 2021年7月15日 20:07
> To: Dong Aisheng <dongas86 at gmail.com>
> Cc: Joakim Zhang <qiangqing.zhang at nxp.com>; Aisheng Dong
> <aisheng.dong at nxp.com>; devicetree <devicetree at vger.kernel.org>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel at lists.infradead.org>; dl-linux-imx <linux-imx at nxp.com>;
> Sascha Hauer <kernel at pengutronix.de>; Rob Herring <robh+dt at kernel.org>;
> Shawn Guo <shawnguo at kernel.org>; linux-can at vger.kernel.org;
> netdev at vger.kernel.org
> Subject: Re: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile
> 
> On 15.07.2021 19:36:06, Dong Aisheng wrote:
> > Then should it be "fsl,imx8mp-flexcan", "fsl,imx8qxp-flexcan" rather
> > than only drop "fsl,imx6q-flexcan"?
> 
> The driver has compatibles for the 8qm, not for the 8qxp:
> 
> |	{ .compatible = "fsl,imx8qm-flexcan", .data =
> &fsl_imx8qm_devtype_data, },
> |	{ .compatible = "fsl,imx8mp-flexcan", .data =
> |&fsl_imx8mp_devtype_data, },

AFAIK, we first design the i.MX8QM FlexCAN and later i.MX8QXP reuses IP from i.MX8QM, so there is no difference for them.

IMHO, IP design is always backwards compatible, then we need list each as fallback compatible string? I think it's unnecessary.

Best Regards,
Joakim Zhang
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


More information about the linux-arm-kernel mailing list