[PATCH 4/4] remoteproc: imx_rproc: fix rsc-table name

Aisheng Dong aisheng.dong at nxp.com
Mon Jul 12 19:47:44 PDT 2021


Hi Mathieu,

Thanks for the feedback.

> From: Mathieu Poirier <mathieu.poirier at linaro.org>
> Sent: Tuesday, July 13, 2021 2:09 AM
> 
> On Tue, Jul 06, 2021 at 10:23:35PM +0800, Dong Aisheng wrote:
> > Usually the dash '-'  is preferred in node name.
> 
> ... And yet the DT binding shows &m4_reserved_sysmem1 and
> &m4_reserved_sysmem2.
> 
> Either change it all or leave as is.

These are phandles and not node names.
So should be ok.

BTW, I've sent V2, could you help review V2 series?
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210707094033.1959752-1-aisheng.dong@nxp.com/

Regards
Aisheng

> 
> Thanks,
> Mathieu
> 
> > So far, not dts in upstream kernel, so we just update node name in
> > driver.
> >
> > Cc: Bjorn Andersson <bjorn.andersson at linaro.org>
> > Cc: Mathieu Poirier <mathieu.poirier at linaro.org>
> > Cc: Peng Fan <peng.fan at nxp.com>
> > Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores
> > booted before Linux Kernel")
> > Signed-off-by: Dong Aisheng <aisheng.dong at nxp.com>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 12de153abb2d..26eb130f3263
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -600,7 +600,7 @@ static int imx_rproc_addr_init(struct imx_rproc
> *priv,
> >  		}
> >  		priv->mem[b].sys_addr = res.start;
> >  		priv->mem[b].size = resource_size(&res);
> > -		if (!strcmp(node->name, "rsc_table"))
> > +		if (!strcmp(node->name, "rsc-table"))
> >  			priv->rsc_table = priv->mem[b].cpu_addr;
> >  		b++;
> >  	}
> > --
> > 2.25.1
> >


More information about the linux-arm-kernel mailing list