[PATCH v12 13/17] counter: Implement signalZ_action_component_id sysfs attribute
David Lechner
david at lechnology.com
Sat Jul 10 09:20:45 PDT 2021
On 7/5/21 3:19 AM, William Breathitt Gray wrote:
> The Generic Counter chrdev interface expects users to supply component
> IDs in order to select Synapses for requests. In order for users to know
> what component ID belongs to which Synapse this information must be
> exposed. The signalZ_action_component_id attribute provides a way for
> users to discover what component ID belongs to the respective Synapse.
>
> Cc: David Lechner <david at lechnology.com>
> Cc: Gwendal Grignou <gwendal at chromium.org>
> Cc: Dan Carpenter <dan.carpenter at oracle.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray at gmail.com>
> ---
I like this better than having to scrape the number from the
attribute name.
Reviewed-by: David Lechner <david at lechnology.com>
> + /* Allocate Counter attribute */
> + counter_attr = devm_kzalloc(dev, sizeof(*counter_attr), GFP_KERNEL);
nit: Comments like this are redundant and can be omitted. All 3 words
in the comment are literally (abbreviated) in the next line of code so
it doesn't add any new/useful information.
More information about the linux-arm-kernel
mailing list