[RFC v2 1/4] drivers: firmware: Add user encrypted key load API support

[Greg KH]

On Fri, Jul 09, 2021 at 08:41:35AM +0000, Nava kishore Manne wrote:
> Hi Greg,
> 
> 	Thanks for providing the review comments.
> Please find my response inline.
> 
> > -----Original Message-----
> > From: Greg KH <gregkh at linuxfoundation.org>
> > Sent: Wednesday, June 9, 2021 3:25 PM
> > To: Nava kishore Manne <navam at xilinx.com>
> > Cc: robh+dt at kernel.org; Michal Simek <michals at xilinx.com>;
> > mdf at kernel.org; trix at redhat.com; arnd at arndb.de; Rajan Vaja
> > <RAJANV at xilinx.com>; Amit Sunil Dhamne <amitsuni at xlnx.xilinx.com>;
> > Tejas Patel <tejasp at xlnx.xilinx.com>; zou_wei at huawei.com; Sai Krishna
> > Potthuri <lakshmis at xilinx.com>; Ravi Patel <RAVIPATE at xilinx.com>;
> > iwamatsu at nigauri.org; Jiaying Liang <jliang at xilinx.com>;
> > devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> > kernel at vger.kernel.org; linux-fpga at vger.kernel.org; git <git at xilinx.com>;
> > chinnikishore369 at gmail.com
> > Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
> > support
> > 
> > On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> > > This patch adds user encrypted key load API to support User key
> > > encrypted images loading use cases from Linux.
> > 
> > What is "user key encrypted images"?  Do we need more documentation
> > here for what this is and how to use it?
> > 
> 
> Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode.
> User can supply a 128-bit Initial Vector and 256-bit key(user key).

Please provide the needed information in the changelog comment.

> For more info please refer here: 
> https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf 

External links always grow stale.

thanks,

greg k-h