[PATCH 2/2] ARM: mcs_spinlock: Drop smp_wmb in arch_mcs_spin_lock_contended()
Will Deacon
will at kernel.org
Wed Jan 27 17:22:42 EST 2021
On Wed, Jan 27, 2021 at 09:01:09PM +0100, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin at nokia.com>
>
> Drop smp_wmb in arch_mcs_spin_lock_contended() after adding in into
> ARCH-independent code.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin at nokia.com>
> ---
> arch/arm/include/asm/mcs_spinlock.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/mcs_spinlock.h b/arch/arm/include/asm/mcs_spinlock.h
> index 529d2cf..d8fa921 100644
> --- a/arch/arm/include/asm/mcs_spinlock.h
> +++ b/arch/arm/include/asm/mcs_spinlock.h
> @@ -8,8 +8,6 @@
> /* MCS spin-locking. */
> #define arch_mcs_spin_lock_contended(lock) \
> do { \
> - /* Ensure prior stores are observed before we enter wfe. */ \
> - smp_mb(); \
I think this is the right place for the barrier, not in the core code.
Will
More information about the linux-arm-kernel
mailing list