[PATCH] ARM: dmabounce: fix NULL check before some freeing functions is not needed

Tian Tao tiantao6 at hisilicon.com
Wed Jan 27 04:03:03 EST 2021


fixed the below warning:
./arch/arm/common/dmabounce.c:565:2-18: WARNING: NULL check before some
freeing functions is not needed.
./arch/arm/common/dmabounce.c:567:2-18: WARNING: NULL check before some
freeing functions is not needed.

Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>
---
 arch/arm/common/dmabounce.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 7996c04..bf1218a 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -561,10 +561,8 @@ void dmabounce_unregister_dev(struct device *dev)
 		BUG();
 	}
 
-	if (device_info->small.pool)
-		dma_pool_destroy(device_info->small.pool);
-	if (device_info->large.pool)
-		dma_pool_destroy(device_info->large.pool);
+	dma_pool_destroy(device_info->small.pool);
+	dma_pool_destroy(device_info->large.pool);
 
 #ifdef STATS
 	if (device_info->attr_res == 0)
-- 
2.7.4




More information about the linux-arm-kernel mailing list