[PATCH v3 2/4] arm64: dts: correct vendor prefix hisi to hisilicon

Arnd Bergmann arnd at kernel.org
Tue Jan 26 17:23:42 EST 2021


On Tue, Dec 8, 2020 at 1:46 PM Zhen Lei <thunder.leizhen at huawei.com> wrote:
>
> The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly
> stated in "vendor-prefixes.yaml".
>
> Fixes: 35ca8168133c ("arm64: dts: Add dts files for Hisilicon Hi3660 SoC")
> Fixes: dd8c7b78c11b ("arm64: dts: Add devicetree for Hisilicon Hi3670 SoC")
> Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
> Cc: Chen Feng <puck.chen at hisilicon.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>

I see this change in the pull request I got, but I'm a bit worried about the
incompatible binding change. Wouldn't the correct path forward be to
list both the correct and the incorrect properties, both in the dts file
and in the driver that interprets the properties?

The binding file in this case would need to list the old name as deprecated,
though I'm not sure how that would work without causing a warning about
the unknown vendor prefix.

        Arnd



More information about the linux-arm-kernel mailing list