[PATCH V2 4/4] perf vendor events: Add JSON metrics for imx8mp DDR Perf

[John Garry]

On 25/01/2021 08:59, Joakim Zhang wrote:
> +   },
> +   {
> +	   "BriefDescription": "bytes of display isp1 read from ddr",

is it proper to have "bytes", while scale unit has KB?

> +	   "MetricName": "imx8mp_ddr_read.isp1",
> +	   "MetricExpr": "imx8_ddr0 at axid\\-read\\,axi_mask\\=0x0000\\,axi_id\\=0x006d@",

eh, does this really even qualify as a "metric"? Seems only a single 
event...

> +	   "ScaleUnit": "9.765625e-4KB",
> +	   "Unit": "imx8_ddr",
> +	   "Compat": "i.MX8MP"
> +   },
> +   {
> +	   "BriefDescription": "bytes of display isp1 write to ddr",
> +	   "MetricName": "imx8mp_ddr_write.isp1",
> +	   "MetricExpr": "imx8_ddr0 at axid\\-write\\,axi_mask\\=0x0000\\,axi_id\\=0x006d@",
> +	   "MetricGroup": "imx8_ddr_DDR_MON",
> +	   "Unit": "imx8_ddr",

why no scale unit here?

> +	   "Compat": "i.MX8MP"

btw, not sure if Arnaldo is ok with you not cc'ing other guys mentioned 
in "performance events subsystem" or "performance events tooling arm64"..

Thanks,
john